Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure examples in bigquery-usage are up to date. #1259

Closed
dhermes opened this issue Dec 1, 2015 · 3 comments
Closed

Make sure examples in bigquery-usage are up to date. #1259

dhermes opened this issue Dec 1, 2015 · 3 comments
Assignees
@tseaver
Labels
api: bigquery Issues related to the BigQuery API.

Comments

@dhermes
Copy link
Contributor

dhermes commented Dec 1, 2015

For example, there is a string

results = client.run_sync_query(query, timeout_ms=1000)

but run_sync_query does not have timeout_ms as an optional argument.
@dhermes dhermes added the api: bigquery Issues related to the BigQuery API. label Dec 1, 2015
@dhermes
Copy link
Contributor Author

dhermes commented Dec 1, 2015

Obviously related to #212, but maybe not worth digging deep on that?

@tseaver tseaver mentioned this issue Dec 4, 2015
Merged
@dhermes dhermes reopened this Jan 18, 2016
@dhermes
Copy link
Contributor Author

dhermes commented Jan 18, 2016

@tseaver Re-opening this after #1392, #1397, #1398 and #1399 were filed. Can you do another pass over bigquery-usage?

@dhermes dhermes added the docs label Jan 18, 2016
@tseaver
Copy link
Contributor

tseaver commented Feb 15, 2016

#1469 addressed the remaining open issues.

@tseaver tseaver closed this as completed Feb 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tseaver tseaver

Labels
api: bigquery Issues related to the BigQuery API.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tseaver @dhermes