Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dns.Client.zone lacks a description parameter. #1721

Closed
theacodes opened this issue Apr 12, 2016 · 2 comments
Closed

dns.Client.zone lacks a description parameter. #1721

theacodes opened this issue Apr 12, 2016 · 2 comments
Assignees
Labels
api: dns Issues related to the Cloud DNS API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@theacodes
Copy link
Contributor

The description parameter is required to the API call to manageZones.create, however, this parameter is not exposed in Client.zone. This leads to the awkward pattern:

zone = client.zone('zone-name', dns_name='example.com.')
zone.description = 'My zone'
zone.create()

Where it should be:

zone = client.zone('zone-name', dns_name='example.com.', description='My zone')
zone.create()
@theacodes theacodes added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: dns Issues related to the Cloud DNS API. labels Apr 12, 2016
@jgeewax
Copy link
Contributor

jgeewax commented Apr 13, 2016

It seems weird that description is required... I don't think it should be required in the client, could we make the "default description" == dns_name on the client side unless someone specifically sets a description?

@theacodes
Copy link
Contributor Author

hmm. Idk. It may be an API-level bug, as the description isn't strictly required in the UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: dns Issues related to the Cloud DNS API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

3 participants