Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable setting 'Blob.storage_class' before upload #3062

Closed
tseaver opened this issue Feb 23, 2017 · 1 comment
Closed

Enable setting 'Blob.storage_class' before upload #3062

tseaver opened this issue Feb 23, 2017 · 1 comment
Assignees
@tseaver
Labels
api: storage Issues related to the Cloud Storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. status: blocked Resolving the issue is dependent on other work. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@tseaver
Copy link
Contributor

tseaver commented Feb 23, 2017

From #3051.

Because of #754, there currently is no point in allowing the user to set storage_class on a blob instance before uploading it: the value won't be transmitted. Once that issue is cleared, we should either: a) allow passing storage_class to Blob.__init__, or b) add a "setter" for the storage_class property (it would need to reject setting values for already-created blobs). We would then need to ensure that the storageClass field was set appropriately in the property mapping sent with the upload.
@tseaver tseaver added api: storage Issues related to the Cloud Storage API. status: blocked Resolving the issue is dependent on other work. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Feb 23, 2017
@tseaver tseaver mentioned this issue Feb 23, 2017
Merged
@danoscarmike danoscarmike added the priority: p2 Moderately-important priority. Fix may not be included in next release. label Feb 28, 2017
@tseaver
Copy link
Contributor Author

tseaver commented Jun 5, 2017

#3328 made storage_class settable before blob creation.

#3051 added a Blob.update_storage_class method which allows changing the storage class via a server-side rewrite.

@tseaver tseaver closed this as completed Jun 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tseaver tseaver

Labels
api: storage Issues related to the Cloud Storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. status: blocked Resolving the issue is dependent on other work. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tseaver @danoscarmike