Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigQuery job.results() still in usage doc #3907

Closed
leo-thumbtack opened this issue Aug 31, 2017 · 5 comments
Closed

BigQuery job.results() still in usage doc #3907

leo-thumbtack opened this issue Aug 31, 2017 · 5 comments
Assignees
Labels
api: bigquery Issues related to the BigQuery API. type: question Request for information or clarification. Not an issue.

Comments

@leo-thumbtack
Copy link

leo-thumbtack commented Aug 31, 2017

Edit by @dhermes: The bigquery/usage.rst doc is out-of-date. We really need to run those samples on CI on a regular basis.


Original: Following https://googlecloudplatform.github.io/google-cloud-python/stable/bigquery/usage.html#querying-data-asynchronous

it worked perfectly with 0.25, with latest version I get exception saying that
QueryJob doesnt have a results() method anymore.

@leo-thumbtack
Copy link
Author

leo-thumbtack commented Aug 31, 2017

@dhermes
Copy link
Contributor

dhermes commented Aug 31, 2017

Thanks for the concern, the interface has indeed changed.

If you check out the release notes:

https://github.com/GoogleCloudPlatform/google-cloud-python/releases/tag/bigquery-0.26.0
https://github.com/GoogleCloudPlatform/google-cloud-python/releases/tag/bigquery-0.27.0

you can keep track of the changes.

For example

Removing results() method from the QueryJob class. Use query_results() instead.

I am going to preemptively close this issue, but let me know if you think there is more to discuss?

@dhermes dhermes closed this as completed Aug 31, 2017
@dhermes dhermes added api: bigquery Issues related to the BigQuery API. type: question Request for information or clarification. Not an issue. labels Aug 31, 2017
@leo-thumbtack
Copy link
Author

maybe update the readme i liked in my first message ?

@dhermes dhermes changed the title Issues with 0.26 and 0.27 vs 0.25 about job.results() BigQuery job.results() still in usage doc Aug 31, 2017
@dhermes dhermes added the docs label Aug 31, 2017
@dhermes dhermes reopened this Aug 31, 2017
@bits01
Copy link

bits01 commented Oct 11, 2017

Please also see #4153

@tswast
Copy link
Contributor

tswast commented Oct 24, 2017

This will be closed by #4245.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. type: question Request for information or clarification. Not an issue.
Projects
None yet
Development

No branches or pull requests

4 participants