Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCS notification convenience methods, pubsub dependency #4097

Closed
tseaver opened this issue Oct 2, 2017 · 3 comments
Closed

GCS notification convenience methods, pubsub dependency #4097

tseaver opened this issue Oct 2, 2017 · 3 comments
Assignees
Labels
api: pubsub Issues related to the Pub/Sub API. api: storage Issues related to the Cloud Storage API. type: question Request for information or clarification. Not an issue.

Comments

@tseaver
Copy link
Contributor

tseaver commented Oct 2, 2017

In #4021, @BrandonY asked for convenience wrapprer(s) for the following:

  • Create the user-supplied topic
  • Set the appropriate IAM policy needed to support bucket notifications
  • Create a subscription to the topic

Adding this support would make storage depend on pubsub (at least optionally), and would complicate our testing story (system tests already add it). Ruby just documents what is required.

@danoscarmike, @lukesneeringer nominated you as the arbitrator for the issue.

@tseaver tseaver added api: pubsub Issues related to the Pub/Sub API. api: storage Issues related to the Cloud Storage API. type: question Request for information or clarification. Not an issue. labels Oct 2, 2017
@BrandonY
Copy link

BrandonY commented Oct 2, 2017

Without this convenience function, everyone who wants to use notifications will have to write a function that invokes around 4 calls:

  • Call GCS to request the name of the appropriate permission for your GCS bucket.
  • Call Pub/Sub to create a topic
  • Call Pub/Sub's IAM interface to add publish permission to the robot that was the response to the first RPC.
  • Call GCS to add notifications to a bucket.

With a convenience method, the whole thing can be shortened to bucket.sendNotifications(topic).

@danoscarmike
Copy link
Contributor

Ack. @BrandonY I'll reach out to you offline.

@lukesneeringer
Copy link
Contributor

This was decided. We are not doing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API. api: storage Issues related to the Cloud Storage API. type: question Request for information or clarification. Not an issue.
Projects
None yet
Development

No branches or pull requests

4 participants