Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add 'py.typed' declaration file #287

Merged
merged 1 commit into from
Nov 18, 2021
Merged

feat: add 'py.typed' declaration file #287

merged 1 commit into from
Nov 18, 2021

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Nov 16, 2021 •
edited
Loading

Check typing under CI using new 'mypy' nox session.

@tseaver
feat: add 'py.typed' declaration file
7be4577 
Check typing using new 'mypy' nox session.
@tseaver tseaver requested review from a team as code owners November 16, 2021 16:36
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 16, 2021
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/google-resumable-media-python API. label Nov 16, 2021
@tseaver
Copy link
Contributor Author

tseaver commented Nov 16, 2021

Note to reviewers: aside from complaints about missing stubs, etc. the mypy check found one "real" issue: both the sync and async versions of ResumableUpload redefined the signature of its inherited _process_upload helper method. I fixed that issue by renaming it (in both places) to _process_resumable_upload.

@tseaver tseaver requested a review from cojenco November 16, 2021 16:39
@tseaver tseaver mentioned this pull request Nov 16, 2021
Closed
@tseaver tseaver requested a review from tswast November 16, 2021 17:59
cojenco
cojenco approved these changes Nov 18, 2021
View reviewed changes
Copy link
Contributor

@cojenco cojenco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! I'll add "py.typed" with changes to python-storage once python 2 deprecation is finalized.

@tseaver tseaver merged commit cee4164 into main Nov 18, 2021
@tseaver tseaver deleted the add-mypy-support branch November 18, 2021 22:32
@release-please release-please bot mentioned this pull request Jan 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cojenco cojenco cojenco approved these changes

@andrewsg andrewsg Awaiting requested review from andrewsg

@busunkim96 busunkim96 Awaiting requested review from busunkim96

@tswast tswast Awaiting requested review from tswast

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/google-resumable-media-python API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tseaver @cojenco