Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use unittest.mock if available rather than deprecated mock module #328

Closed
major opened this issue May 19, 2022 · 0 comments · Fixed by #329
Closed

Use unittest.mock if available rather than deprecated mock module #328

major opened this issue May 19, 2022 · 0 comments · Fixed by #329
Assignees
@andrewsg
Labels
api: storage Issues related to the googleapis/google-resumable-media-python API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@major
Copy link
Contributor

major commented May 19, 2022

Environment details

  • OS type and version: Fedora 36
  • Python version: 3.10.4
  • pip version: 22.0.4
  • google-resumable-media version: main branch

Steps to reproduce

  1. Run tests on Python 3.10 without mock installed
  2. Test fail due to mock import

I'll open a PR to fix in a moment.
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/google-resumable-media-python API. label May 19, 2022
@major major mentioned this issue May 19, 2022
Merged
@andrewsg andrewsg self-assigned this May 19, 2022
@andrewsg andrewsg added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewsg andrewsg

Labels
api: storage Issues related to the googleapis/google-resumable-media-python API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Use unittest.mock major/google-resumable-media-python
2 participants
@major @andrewsg