-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add google-auth to aiohttp extra #386
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Alternatively, we could add google-auth
as an extra, and add conditional logic here to raise an exception to let users know that they need to install the google-auth
extra.
https://github.com/googleapis/google-resumable-media-python/blob/main/google/_async_resumable_media/requests/_request_helpers.py#L26
@parthea an extra sounds best to me. |
+1 to adding an extra instead as the async support is experimental and subject to change. Additionally, we're also planning to integrate this library into python-storage in the near future. I'm trying to understand how the namespace packaging changes would impact this if any; cc @andrewsg |
I would prefer extra, or else removing async testing. Async support is currently theoretical and not documented or supported. |
Out of curiosity, is there anyone working on stabilizing the Async API? |
We don't have it on our roadmap at present as it would require a complete rewrite of python-storage, as well as an additional rewrite of this library in order to avoid having two separate versions of the library that need to be maintained simultaneously. This doesn't mean that async won't happen at all, just that it's not scheduled as of yet. |
Okay awesome. Are you a good point of contact for this? I have some questions I want to take offline. |
Yep, feel free to reach out. |
I will fix the error tomorrow. Looks like some of the doc tests also use google auth |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #384