From f64cec358681cb37954167de9baae515c8061ae3 Mon Sep 17 00:00:00 2001 From: Lisandro Mc Gough Date: Fri, 8 May 2020 14:17:38 -0300 Subject: [PATCH 1/2] fix: accept `201 Created` as valid upload response. Supersedes: #125 Fixes: #124 --- google/resumable_media/_upload.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/google/resumable_media/_upload.py b/google/resumable_media/_upload.py index 8a3cc645..3a98464f 100644 --- a/google/resumable_media/_upload.py +++ b/google/resumable_media/_upload.py @@ -501,7 +501,7 @@ def _process_initiate_response(self, response): """ _helpers.require_status_code( response, - (http_client.OK,), + (http_client.OK, http_client.CREATED), self._get_status_code, callback=self._make_invalid, ) From 704b91cba17aec47a58c4a4186f325a78689e03b Mon Sep 17 00:00:00 2001 From: Tres Seaver Date: Thu, 23 Jul 2020 14:05:01 -0400 Subject: [PATCH 2/2] tests: accomodate unit test to extra argument. --- tests/unit/test__upload.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/unit/test__upload.py b/tests/unit/test__upload.py index 689065e9..18411ca8 100644 --- a/tests/unit/test__upload.py +++ b/tests/unit/test__upload.py @@ -507,9 +507,10 @@ def test__process_initiate_response_non_200(self): error = exc_info.value assert error.response is response - assert len(error.args) == 4 + assert len(error.args) == 5 assert error.args[1] == 403 assert error.args[3] == 200 + assert error.args[4] == 201 def test__process_initiate_response(self): upload = _upload.ResumableUpload(RESUMABLE_URL, ONE_MB)