Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add additional parameters to CsvOptions and ParquetOptions #3370

Merged
merged 5 commits into from
Jun 28, 2024
Merged

feat: add additional parameters to CsvOptions and ParquetOptions #3370

merged 5 commits into from
Jun 28, 2024
+79 −9

Conversation

PhongChuong
Copy link
Contributor

@PhongChuong PhongChuong commented Jun 27, 2024 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #3369 ☕️

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/java-bigquery API. labels Jun 27, 2024
@PhongChuong PhongChuong added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 27, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 27, 2024
@PhongChuong PhongChuong marked this pull request as ready for review June 27, 2024 15:52
@PhongChuong PhongChuong requested review from a team as code owners June 27, 2024 15:52
shollyman
shollyman approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, a couple of minor questions.

google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/CsvOptions.java Outdated Show resolved Hide resolved
google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/ParquetOptions.java Show resolved Hide resolved
PhongChuong
PhongChuong commented Jun 27, 2024
View reviewed changes
Copy link
Contributor Author

@PhongChuong PhongChuong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review. Updated to address the comments. PTAL.

google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/ParquetOptions.java Show resolved Hide resolved
google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/CsvOptions.java Outdated Show resolved Hide resolved
@PhongChuong PhongChuong merged commit 34f16fb into main Jun 28, 2024
20 checks passed
@PhongChuong PhongChuong deleted the ExternalTableDefinitionOptions branch June 28, 2024 14:53
@release-please release-please bot mentioned this pull request Jul 3, 2024
Merged
This was referenced Jul 30, 2024
Closed
Closed
Closed
lqiu96 pushed a commit that referenced this pull request Aug 28, 2024
@PhongChuong @gcf-owl-bot @lqiu96
feat: add additional parameters to CsvOptions and ParquetOptions (#3370)
a626bc6 
* feat: add additional parameters to CsvOptions and ParquetOptions

* fix lint

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Addressed review comments

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shollyman shollyman shollyman approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/java-bigquery API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support additional CsvOptions and ParquetOptions
2 participants
@PhongChuong @shollyman