feat: Add support for vector search with Query#findNearest #1827

MarkDuckworth · 2024-09-17T17:11:28Z

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

conventional-commit-lint-gcf · 2024-09-17T17:11:33Z

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

…duckworth/find-nearest

google-cloud-firestore/src/main/java/com/google/cloud/firestore/FindNearestOptions.java

google-cloud-firestore/src/main/java/com/google/cloud/firestore/GenericQuerySnapshot.java

google-cloud-firestore/src/main/java/com/google/cloud/firestore/QueryApiStreamObserver.java

google-cloud-firestore/src/main/java/com/google/cloud/firestore/StreamableQuery.java

google-cloud-firestore/src/main/java/com/google/cloud/firestore/Query.java

tom-andersen

I am still going through PR, but I want to share what I found so far.

google-cloud-firestore/src/main/java/com/google/cloud/firestore/GenericQuerySnapshot.java

google-cloud-firestore/src/main/java/com/google/cloud/firestore/Query.java

google-cloud-firestore/src/main/java/com/google/cloud/firestore/QuerySnapshot.java

google-cloud-firestore/src/main/java/com/google/cloud/firestore/VectorQuerySnapshot.java

google-cloud-firestore/src/main/java/com/google/cloud/firestore/Query.java

google-cloud-firestore/src/main/java/com/google/cloud/firestore/VectorQuery.java

…duckworth/find-nearest

…va-firestore into markduckworth/find-nearest

tom-andersen · 2024-09-27T20:54:43Z

google-cloud-firestore/src/main/java/com/google/cloud/firestore/GenericQuerySnapshot.java

+      QueryT query,
+      Timestamp readTime,
+      final List<QueryDocumentSnapshot> documents,
+      final DocumentSet documentSet,


This is of slightly greater concern because documentSet is also omitted from equals method.

I prefer this get fixed.

google-cloud-firestore/src/main/java/com/google/cloud/firestore/VectorQueryOptions.java

google-cloud-firestore/src/test/java/com/google/cloud/firestore/VectorQueryTest.java

google-cloud-firestore/src/main/java/com/google/cloud/firestore/Query.java

google-cloud-firestore/src/main/java/com/google/cloud/firestore/VectorQuery.java

google-cloud-firestore/src/main/java/com/google/cloud/firestore/StreamableQuery.java

google-cloud-firestore/src/main/java/com/google/cloud/firestore/VectorQuery.java

…duckworth/find-nearest

…cument set.

tom-andersen

Nice!

Refactor to support find nearest

a971555

product-auto-label bot added size: xl Pull request size is extra large. api: firestore Issues related to the googleapis/java-firestore API. labels Sep 17, 2024

MarkDuckworth added 2 commits September 17, 2024 13:33

Merge branch 'main' of github.com:googleapis/java-firestore into mark…

44d364d

…duckworth/find-nearest

FindNearest with tests

8fe28ce

MarkDuckworth changed the title ~~WIP: Find nearest~~ Find nearest Sep 18, 2024

MarkDuckworth marked this pull request as ready for review September 18, 2024 14:43

MarkDuckworth requested a review from a team as a code owner September 18, 2024 14:43

MarkDuckworth added 2 commits September 18, 2024 09:08

Cleanup and comments

151f245

Cleanup and addressing API breaking changes

c2da4a8

MarkDuckworth changed the title ~~Find nearest~~ feat: Add support for vector search with Query#findNearest Sep 18, 2024

MarkDuckworth requested a review from wu-hui September 18, 2024 15:17

MarkDuckworth assigned wu-hui Sep 18, 2024

wu-hui reviewed Sep 23, 2024

View reviewed changes

wu-hui assigned MarkDuckworth and unassigned wu-hui Sep 23, 2024

PR feedback and adding tests

dff55dc

MarkDuckworth assigned tom-andersen Sep 26, 2024

tom-andersen requested changes Sep 27, 2024

View reviewed changes

google-cloud-firestore/src/main/java/com/google/cloud/firestore/Query.java Outdated Show resolved Hide resolved

google-cloud-firestore/src/main/java/com/google/cloud/firestore/VectorQuery.java Outdated Show resolved Hide resolved

MarkDuckworth and others added 3 commits September 27, 2024 11:14

PR comment changes

a29c6b5

Merge branch 'main' of github.com:googleapis/java-firestore into mark…

96a3940

…duckworth/find-nearest

chore: generate libraries at Fri Sep 27 17:15:13 UTC 2024

b391efb

cloud-java-bot requested a review from a team as a code owner September 27, 2024 17:17

MarkDuckworth and others added 5 commits September 27, 2024 11:30

Fix dependency check

7bd43aa

Merge branch 'markduckworth/find-nearest' of github.com:googleapis/ja…

58756e0

…va-firestore into markduckworth/find-nearest

chore: generate libraries at Fri Sep 27 17:33:40 UTC 2024

264e103

PR remove unnecessary override

bb83ee7

Merge branch 'markduckworth/find-nearest' of github.com:googleapis/ja…

31e9be2

…va-firestore into markduckworth/find-nearest

MarkDuckworth requested a review from tom-andersen September 27, 2024 20:10

tom-andersen requested changes Sep 27, 2024

View reviewed changes

google-cloud-firestore/src/main/java/com/google/cloud/firestore/StreamableQuery.java Outdated Show resolved Hide resolved

google-cloud-firestore/src/main/java/com/google/cloud/firestore/VectorQuery.java Outdated Show resolved Hide resolved

MarkDuckworth and others added 8 commits October 1, 2024 13:25

PR feedback

1f61461

Merge branch 'main' of github.com:googleapis/java-firestore into mark…

f29120c

…duckworth/find-nearest

chore: generate libraries at Tue Oct 1 19:36:20 UTC 2024

87fcff4

Example code

5fa33f5

javadoc fix

1fe96df

Merge branch 'main' of github.com:googleapis/java-firestore into mark…

c606e57

…duckworth/find-nearest

Refactor GenericQuerySnapshot so the constructor does not accept a do…

7cfab37

…cument set.

chore: generate libraries at Tue Oct 1 21:53:10 UTC 2024

84a8f8b

MarkDuckworth requested a review from tom-andersen October 1, 2024 21:59

tom-andersen approved these changes Oct 2, 2024

View reviewed changes

tom-andersen removed their assignment Oct 2, 2024

MarkDuckworth merged commit 4ad463a into main Oct 2, 2024
21 of 22 checks passed

MarkDuckworth deleted the markduckworth/find-nearest branch October 2, 2024 15:31

release-please bot mentioned this pull request Oct 2, 2024

chore(main): release 3.27.0 #1861

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add support for vector search with Query#findNearest #1827

feat: Add support for vector search with Query#findNearest #1827

MarkDuckworth commented Sep 17, 2024

conventional-commit-lint-gcf bot commented Sep 17, 2024 •

edited

Loading

tom-andersen left a comment

tom-andersen Sep 27, 2024

tom-andersen left a comment

feat: Add support for vector search with Query#findNearest #1827

feat: Add support for vector search with Query#findNearest #1827

Conversation

MarkDuckworth commented Sep 17, 2024

conventional-commit-lint-gcf bot commented Sep 17, 2024 • edited Loading

tom-andersen left a comment

Choose a reason for hiding this comment

tom-andersen Sep 27, 2024

Choose a reason for hiding this comment

tom-andersen left a comment

Choose a reason for hiding this comment

conventional-commit-lint-gcf bot commented Sep 17, 2024 •

edited

Loading