Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Do not expose GAX BatchingSettings #1247

Open
losalex opened this issue Jan 11, 2023 · 2 comments
Open

feat: Do not expose GAX BatchingSettings #1247

losalex opened this issue Jan 11, 2023 · 2 comments
Labels
api: logging Issues related to the googleapis/java-logging API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@losalex
Copy link
Contributor

losalex commented Jan 11, 2023

As part of the fix for 953 the GAX BatchingSettings was exposed to customers. We should hide GAX dependency and then expose it in java-logback as well

@losalex losalex added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Jan 11, 2023
@losalex losalex self-assigned this Jan 11, 2023
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/java-logging API. label Jan 11, 2023
@meredithslota
Copy link
Contributor

@losalex — I see the discussion thread in googleapis/java-logging-logback#977 but it's not clear to me why we wouldn't expose these. The comment thread just mentioned that the code will be "cleaner" but doesn't this limit the ability for users to configure this themselves?

@losalex
Copy link
Contributor Author

losalex commented May 31, 2023

@losalex — I see the discussion thread in googleapis/java-logging-logback#977 but it's not clear to me why we wouldn't expose these. The comment thread just mentioned that the code will be "cleaner" but doesn't this limit the ability for users to configure this themselves?

This is about exposing GAX types which might require reference for GAX in customer's code. Today, all configuration is exposed through LoggingOptions which ideally should not contain dependencies on libraries used internally. For example, we might not need GAX dependencies if we printing logs to console - so if we want to create a separate, lightweight package for java-logback which only prints logs to stdout, we still will need GAX dependency...

@losalex losalex removed their assignment Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the googleapis/java-logging API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

2 participants