Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include thread name in traces #3173

Merged
merged 5 commits into from
Jul 3, 2024
Merged

Conversation

olavloite
Copy link
Collaborator

Include the name of the tread that is executing a statement in the traces that are generated, so it is easier to debug concurrency issues. Sometimes, it is not clear whether a statement is being executed by a background worker thread or the main thread.

Include the name of the tread that is executing a statement in the
traces that are generated, so it is easier to debug concurrency
issues. Sometimes, it is not clear whether a statement is being
executed by a background worker thread or the main thread.
@olavloite olavloite requested review from a team as code owners June 24, 2024 10:05
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/java-spanner API. labels Jun 24, 2024
@olavloite olavloite added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Jul 3, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 3, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit 92b1e07 into main Jul 3, 2024
32 of 34 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 3, 2024
@gcf-merge-on-green gcf-merge-on-green bot deleted the trace-thread-name branch July 3, 2024 07:50
surbhigarg92 pushed a commit to surbhigarg92/java-spanner that referenced this pull request Jul 3, 2024
Include the name of the tread that is executing a statement in the traces that are generated, so it is easier to debug concurrency issues. Sometimes, it is not clear whether a statement is being executed by a background worker thread or the main thread.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants