Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an example of how to change the oauth endpoint #1972

Closed
wants to merge 1 commit into from
Closed

Add an example of how to change the oauth endpoint #1972

wants to merge 1 commit into from

Conversation

DKbyo
Copy link

@DKbyo DKbyo commented Apr 5, 2023

Fixes #1971

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the googleapis/java-storage API. labels Apr 5, 2023
sydney-munro
sydney-munro reviewed Jun 18, 2024
View reviewed changes
samples/snippets/src/main/java/com/example/storage/bucket/SetClientEndpoint.java

public class SetClientEndpoint {

public static ServiceAccountCredentials setOAuthEndpoint(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally we would make a seperate sample (including a seperate class, test etc) if we were going to add a sample like this and not add it into the existing sample for another use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sydney-munro sydney-munro sydney-munro left review comments

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/java-storage API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve the example of setClientEndpoint adding how to change oauth endpoint
2 participants
@DKbyo @sydney-munro