Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include invocation-id for resumable PUTs #2047

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

BenWhitehead
Copy link
Collaborator

Change BlobWriteChannel to us Retrying.run so it will receive an invocation id

Change BlobWriteChannel to us Retrying.run so it will receive an invocation id
@BenWhitehead BenWhitehead added the owlbot:ignore instruct owl-bot to ignore a PR label Jun 5, 2023
@BenWhitehead BenWhitehead requested a review from a team as a code owner June 5, 2023 18:06
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the googleapis/java-storage API. labels Jun 5, 2023
@@ -186,7 +186,9 @@ private static StorageException unrecoverableState(
@Override
protected void flushBuffer(final int length, final boolean lastChunk) {
try {
runWithRetries(
Retrying.run(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am IIUC runWithRetries did not use InvocationId support and using Retrying.run() will address that?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct

@BenWhitehead BenWhitehead merged commit a590ae3 into main Jun 5, 2023
@BenWhitehead BenWhitehead deleted the fix-put-invocation-id branch June 5, 2023 18:46
gcf-merge-on-green bot pushed a commit that referenced this pull request Jun 8, 2023
🤖 I have created a release *beep* *boop*
---


## [2.22.4](https://togithub.com/googleapis/java-storage/compare/v2.22.3...v2.22.4) (2023-06-07)


### Bug Fixes

* Include invocation-id for resumable PUTs ([#2047](https://togithub.com/googleapis/java-storage/issues/2047)) ([a590ae3](https://togithub.com/googleapis/java-storage/commit/a590ae3856fe8cccde17def5ca6bef8cfeed5073))


### Documentation

* Add documentation about quantum write alignment, use of ObjectChecksums, Bucket.name format, and Object.delete_time ([#2032](https://togithub.com/googleapis/java-storage/issues/2032)) ([c39ec13](https://togithub.com/googleapis/java-storage/commit/c39ec13469342ed947b12dd7ab3d301ca1d4d01b))


### Dependencies

* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.11.0 ([#2050](https://togithub.com/googleapis/java-storage/issues/2050)) ([88fffbd](https://togithub.com/googleapis/java-storage/commit/88fffbd56746ff212441fafd1e213177feac0cac))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/java-storage API. owlbot:ignore instruct owl-bot to ignore a PR size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants