Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grpc): return error if credentials are detected to be null #2142

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

BenWhitehead
Copy link
Collaborator

There are some scenarios where application default credentials resolution results in null.

Add an explicit check to provide a more useful error message than NullPointerException.

@BenWhitehead BenWhitehead added the owlbot:ignore instruct owl-bot to ignore a PR label Jul 27, 2023
@BenWhitehead BenWhitehead requested a review from a team as a code owner July 27, 2023 17:49
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: storage Issues related to the googleapis/java-storage API. labels Jul 27, 2023
@BenWhitehead BenWhitehead merged commit b61a976 into main Jul 27, 2023
14 checks passed
@BenWhitehead BenWhitehead deleted the null-creds-check branch July 27, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/java-storage API. owlbot:ignore instruct owl-bot to ignore a PR size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants