Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update implementation of readAllBytes and downloadTo to be more robust to retryable errors #2305

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

BenWhitehead
Copy link
Collaborator

Additional small changes to bring http and grpc implementation into conformance with each other.

Much of this also serves as prework to the grpc retry conformance tests enablement after the next release of testbench.

@BenWhitehead BenWhitehead added the owlbot:ignore instruct owl-bot to ignore a PR label Nov 15, 2023
@BenWhitehead BenWhitehead requested a review from a team as a code owner November 15, 2023 21:26
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: storage Issues related to the googleapis/java-storage API. labels Nov 15, 2023
@BenWhitehead
Copy link
Collaborator Author

The grpc retry conformance tests can be enabled once googleapis/storage-testbench#573 is merged, released and we receive the renovate pr to update the version.

Base automatically changed from fix/auto-gzip-handling to main November 15, 2023 23:36
@cojenco
Copy link
Contributor

cojenco commented Nov 16, 2023

The grpc retry conformance tests can be enabled once googleapis/storage-testbench#573 is merged, released and we receive the renovate pr to update the version.

Thanks again Ben! The latest changes were just released in testbench v0.40.0

…robust to retryable errors

Additional small changes to bring http and grpc implementation into conformance with each other.

Much of this also serves as pre-work to the grpc retry conformance tests enablement after the next release of testbench.
@BenWhitehead BenWhitehead merged commit 21821da into main Nov 17, 2023
20 checks passed
@BenWhitehead BenWhitehead deleted the test/retry/grpc branch November 17, 2023 19:23
sydney-munro added a commit that referenced this pull request Dec 6, 2023
…be more robust to retryable errors (#2305)"

This reverts commit 21821da.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/java-storage API. owlbot:ignore instruct owl-bot to ignore a PR size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants