fix: add a workaround to make sure grpc clients' hosts always match their universe domain #2588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…heir universe domains
product-auto-label
bot
added
size: s
BenWhitehead
approved these changes
Jun 17, 2024
| @@ -600,7 +600,12 @@ public GrpcStorageOptions.Builder setBlobWriteSessionConfig( | |||
| @BetaApi | |||
| @Override | |||
| public GrpcStorageOptions build() { | |||
| return new GrpcStorageOptions(this, defaults()); | |||
| GrpcStorageOptions options = new GrpcStorageOptions(this, defaults()); | |||
| if (options.getUniverseDomain() != null) { | |||
There was a problem hiding this comment.
Can we add a todo-link to the issue to be fixed in sdk-platform-java? Merge away afterward.
JesseLovelace
added
kokoro:run
yoshi-kokoro
removed
kokoro:run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround in place until googleapis/sdk-platform-java#2911 is fixed