Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable grpc.lb.locality label for client-side metrics #2659

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

frankyn
Copy link
Member

@frankyn frankyn commented Aug 1, 2024

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: storage Issues related to the googleapis/java-storage API. labels Aug 1, 2024
@frankyn frankyn marked this pull request as ready for review August 1, 2024 20:02
@frankyn frankyn requested a review from a team as a code owner August 1, 2024 20:02
@danielduhh
Copy link
Contributor

tests ?

@frankyn frankyn added the status: blocked Resolving the issue is dependent on other work. label Aug 2, 2024
@frankyn
Copy link
Member Author

frankyn commented Aug 2, 2024

Requires manually testing this in a small app; I'll work with @JesseLovelace when he's back.

@frankyn frankyn merged commit b681ee0 into main Aug 8, 2024
20 of 21 checks passed
@frankyn frankyn deleted the locality-label branch August 8, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/java-storage API. size: xs Pull request size is extra small. status: blocked Resolving the issue is dependent on other work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants