From 5d4a7db2e7b3619c3746dc8523dce3abdaef86bb Mon Sep 17 00:00:00 2001 From: BenWhitehead Date: Tue, 17 Oct 2023 15:41:58 -0400 Subject: [PATCH] fix: remove PCU internals which should be hidden --- .../clirr-ignored-differences.xml | 16 ++++++++++++++++ ...lelCompositeUploadBlobWriteSessionConfig.java | 6 +++--- 2 files changed, 19 insertions(+), 3 deletions(-) diff --git a/google-cloud-storage/clirr-ignored-differences.xml b/google-cloud-storage/clirr-ignored-differences.xml index c7189a7a9..b3e4b99f7 100644 --- a/google-cloud-storage/clirr-ignored-differences.xml +++ b/google-cloud-storage/clirr-ignored-differences.xml @@ -15,4 +15,20 @@ * writeAndClose(*) + + + 7009 + com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig$PartCleanupStrategy + boolean isDeleteAllOnError() + + + 7009 + com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig$PartCleanupStrategy + boolean isDeletePartsOnSuccess() + + + 7009 + com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig$PartNamingStrategy + java.lang.String fmtFields(*) + diff --git a/google-cloud-storage/src/main/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig.java b/google-cloud-storage/src/main/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig.java index 9a964e7a9..7b9c78f58 100644 --- a/google-cloud-storage/src/main/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig.java +++ b/google-cloud-storage/src/main/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig.java @@ -467,7 +467,7 @@ String fmtName(String ultimateObjectName, PartRange partRange) { return fmtFields(randomKey, nameDigest, partRange.encode()); } - protected abstract String fmtFields(String randomKey, String nameDigest, String partRange); + abstract String fmtFields(String randomKey, String nameDigest, String partRange); /** * Default strategy in which no stable prefix is defined. @@ -588,11 +588,11 @@ private PartCleanupStrategy(boolean deletePartsOnSuccess, boolean deleteAllOnErr this.deleteAllOnError = deleteAllOnError; } - public boolean isDeletePartsOnSuccess() { + boolean isDeletePartsOnSuccess() { return deletePartsOnSuccess; } - public boolean isDeleteAllOnError() { + boolean isDeleteAllOnError() { return deleteAllOnError; }