IAvroRows serializedBinaryRows typedef is a Buffer but defined as (Uint8Array|string|null)

[kitsunde]

Avro's Type.decode expects a Buffer and serializedBinaryRows is a Buffer, but it's defined as (Uint8Array|string|null) which shows up as a type issue.

Presumably either the typedef is missing, or serializedBinaryRows is wrong.

[shollyman]

This is a generated API. I'm not familiar with the Avro library you're using, but this sounds like a case where you need to wrap the serialized row data in a buffer before passing it to the Avro decode?

[kitsunde]

This is a generated API. I'm not familiar with the Avro library you're using, but this sounds like a case where you need to wrap the serialized row data in a buffer before passing it to the Avro decode?

This is the same library your examples are using but not the actual issue.

The typedef for the property is different from the type of the property. It's defined as UInt8Array in this library, but it is a Buffer when executing.

[kitsunde]

To be clear:

nodejs-bigquery-storage/protos/protos.d.ts

Line 440 in b2aa964

serializedBinaryRows?: (Uint8Array|string|null);

This property is a Buffer when executing not a UInt8Array.

So this

nodejs-bigquery-storage/samples/quickstart.js

Line 117 in f7ba708

data.avroRows.serializedBinaryRows,

will get highlighted as passing the wrong type because avro.decode expects a Buffer not a UInt8Array and it actually is a Buffer when executing.

[shollyman]

Status: exploring potential annotation changes via internal issue 277340507.

[alvarowolfx]

Those typescript annotations are generated by protobufjs and we apply some fixes in our gax-nodejs tools. I've just opened this PR to apply the fix in our tool as it's faster for us to land those kind of improvements.

googleapis/gax-nodejs#1652