Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pass Query.wrapIntegers to job.getQueryResults #1191

Merged
merged 4 commits into from
Mar 17, 2023
Merged

fix: pass Query.wrapIntegers to job.getQueryResults #1191

merged 4 commits into from
Mar 17, 2023

Conversation

alvarowolfx
Copy link
Contributor

Query.wrapIntegers was being ignored and not passed to job.getQueryResults when used in bigquery.query.

@alvarowolfx alvarowolfx requested a review from a team as a code owner March 10, 2023 20:49
@alvarowolfx alvarowolfx requested review from a team and prash-mi March 10, 2023 20:49
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/nodejs-bigquery API. labels Mar 10, 2023
@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 10, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 10, 2023
@alvarowolfx
Copy link
Contributor Author

Resolves issue reported on #6 (comment)

@alvarowolfx alvarowolfx mentioned this pull request Mar 10, 2023
Closed
@alvarowolfx alvarowolfx assigned alvarowolfx and unassigned loferris Mar 13, 2023
@alvarowolfx alvarowolfx requested a review from a team as a code owner March 16, 2023 19:00
feywind
feywind approved these changes Mar 17, 2023
View reviewed changes
Copy link
Contributor

@feywind feywind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall comment, from your car mechanic telling you it might be time to get an oil change 😹 It might be good for someone to do a PR that's just a pass of fixing up linting errors. It looks like the repo has accumulated a few.

src/bigquery.ts
@@ -927,7 +927,7 @@ export class BigQuery extends Service {
'value ' +
value.integerValue +
" is out of bounds of 'Number.MAX_SAFE_INTEGER'.\n" +
"To prevent this error, please consider passing 'options.wrapNumbers' as\n" +
"To prevent this error, please consider passing 'options.wrapIntegers' as\n" +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know the history of the wrapNumbers vs wrapIntegers, but it won't be a breaking change, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it was a typo, because the option available to users is wrapIntegers so this is just fixing it.

@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 17, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 17, 2023
@alvarowolfx alvarowolfx added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 17, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 17, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit fb13510 into googleapis:main Mar 17, 2023
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 17, 2023
@release-please release-please bot mentioned this pull request Mar 17, 2023
Merged
This was referenced Mar 28, 2023
Closed
Closed
@github-actions github-actions bot mentioned this pull request Mar 28, 2023
Closed
This was referenced Apr 17, 2023
Closed
Closed
Closed
This was referenced Sep 14, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feywind feywind feywind approved these changes

@shollyman shollyman shollyman approved these changes

@prash-mi prash-mi Awaiting requested review from prash-mi

@steffnay steffnay Awaiting requested review from steffnay

Assignees

@alvarowolfx alvarowolfx

Labels
api: bigquery Issues related to the googleapis/nodejs-bigquery API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alvarowolfx @shollyman @feywind @loferris