Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed the closed client test #1138

Merged

Conversation

danieljbruce
Copy link
Contributor

This PR fixes a flakey test. With this new fix we wait for instances to get created before doing anything else with the instance.

@danieljbruce danieljbruce requested review from a team as code owners August 22, 2022 14:46
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigtable Issues related to the googleapis/nodejs-bigtable API. labels Aug 22, 2022
@danieljbruce danieljbruce changed the title fixed the closed client test fix: fixed the closed client test Aug 22, 2022
@conventional-commit-lint-gcf
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@danieljbruce danieljbruce added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 22, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 22, 2022
@danieljbruce danieljbruce merged commit 7f6f0e6 into googleapis:main Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/nodejs-bigtable API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants