Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lastRowKey and prevRowKey in chunk transformer #354

Closed
sduskis opened this issue Nov 6, 2018 · 1 comment
Closed

lastRowKey and prevRowKey in chunk transformer #354

sduskis opened this issue Nov 6, 2018 · 1 comment
Assignees
@sduskis
Labels
api: bigtable Issues related to the googleapis/nodejs-bigtable API. type: cleanup An internal cleanup or hygiene concern.

Comments

@sduskis
Copy link
Contributor

sduskis commented Nov 6, 2018 •
edited
Loading

ChunkTransformer defines two variables that are used for the same function: lastRowKey and prevRowKey. There should be only one variable. Also, that variable should not be changed in reset().
@JustinBeckwith JustinBeckwith added the type: cleanup An internal cleanup or hygiene concern. label Nov 6, 2018
@muraliQlogic

This comment has been minimized.

Sign in to view
@muraliQlogic muraliQlogic mentioned this issue Nov 6, 2018
Merged
3 tasks
@google-cloud-label-sync google-cloud-label-sync bot added the api: bigtable Issues related to the googleapis/nodejs-bigtable API. label Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sduskis sduskis

Labels
api: bigtable Issues related to the googleapis/nodejs-bigtable API. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sduskis @JustinBeckwith @muraliQlogic