feat: Query filters for datastore #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
kolea2
added
the
do not merge
kolea2
suggested changes
May 18, 2022
| @@ -75,7 +75,10 @@ describe('Query', () => { | |||
| .filter('name', '=', 'Title') | |||
| .filter('count', '>', 20) | |||
| .filter('size', '<', 10) | |||
| .filter('something', '>=', 11); | |||
| .filter('something', '>=', 11) | |||
There was a problem hiding this comment.
lgtm, please at some system tests as well
product-auto-label
bot
added
size: m
danieljbruce
added
kokoro:run
yoshi-kokoro
removed
kokoro:run
kolea2
approved these changes
Jun 13, 2022
kolea2
removed
the
do not merge
danieljbruce
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
danieljbruce
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supports three more types of query filters and provides tests for those new filters too to ensure they can be used in datastore.