Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Reenable staleness bot #632

Merged
merged 6 commits into from
Apr 16, 2022
Merged

fix: Reenable staleness bot #632

merged 6 commits into from
Apr 16, 2022

Conversation

losalex
Copy link
Contributor

@losalex losalex commented Apr 11, 2022

Reenable staleness bot on the repo

@losalex
Reenable staleness bot
56179bb 
Reenable staleness bot on the repo
@losalex losalex requested review from a team as code owners April 11, 2022 19:35
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Apr 11, 2022
@product-auto-label product-auto-label bot added the api: clouderrorreporting Issues related to the googleapis/nodejs-error-reporting API. label Apr 11, 2022
@product-auto-label product-auto-label bot added size: u Pull request is empty. and removed size: xs Pull request size is extra small. labels Apr 11, 2022
@losalex losalex changed the title Reenable staleness bot fix: Reenable staleness bot Apr 15, 2022
@losalex losalex assigned losalex and unassigned donmccasland Apr 15, 2022
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: u Pull request is empty. labels Apr 15, 2022
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Apr 15, 2022
minherz
minherz approved these changes Apr 15, 2022
View reviewed changes
Copy link
Contributor

@minherz minherz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am concerned about replacing copy() with move(). what is a reason?

owlbot.py Outdated Show resolved Hide resolved
@losalex
Copy link
Contributor Author

losalex commented Apr 16, 2022 •
edited
Loading

i am concerned about replacing copy() with move(). what is a reason?

Copy/paste... copy() and move() both works just same in this case

@losalex losalex merged commit b56836e into main Apr 16, 2022
@losalex losalex deleted the losalex-patch-1 branch April 16, 2022 06:36
@release-please release-please bot mentioned this pull request Apr 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minherz minherz minherz approved these changes

Assignees

@losalex losalex

Labels
api: clouderrorreporting Issues related to the googleapis/nodejs-error-reporting API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@losalex @minherz @donmccasland