Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix duplicates in Query.stream() with back pressure #1806

Merged
merged 3 commits into from
Jan 3, 2023
Merged

fix: fix duplicates in Query.stream() with back pressure #1806

merged 3 commits into from
Jan 3, 2023

Conversation

dconeybe
Copy link
Contributor

Fixes #1790

Googlers see b/255772813 for some extra context.

@dconeybe dconeybe added the api: firestore Issues related to the googleapis/nodejs-firestore API. label Dec 20, 2022
@dconeybe dconeybe self-assigned this Dec 20, 2022
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Dec 20, 2022
@dconeybe dconeybe marked this pull request as ready for review December 20, 2022 14:19
@dconeybe dconeybe requested review from a team as code owners December 20, 2022 14:19
@dconeybe dconeybe added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 20, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 20, 2022
MarkDuckworth
MarkDuckworth approved these changes Dec 21, 2022
View reviewed changes
Copy link
Contributor

@MarkDuckworth MarkDuckworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dconeybe dconeybe mentioned this pull request Dec 22, 2022
Closed
@dconeybe dconeybe merged commit a5b680d into main Jan 3, 2023
@dconeybe dconeybe deleted the dconeybe/DuplicateDocFixIssue1790_Squashed branch January 3, 2023 15:01
@release-please release-please bot mentioned this pull request Jan 3, 2023
Merged
@dconeybe dconeybe mentioned this pull request Sep 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkDuckworth MarkDuckworth MarkDuckworth approved these changes

Assignees

@MarkDuckworth MarkDuckworth

@dconeybe dconeybe

Labels
api: firestore Issues related to the googleapis/nodejs-firestore API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

15 duplicate documents from query.stream after retry
2 participants
@dconeybe @MarkDuckworth