Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update synth.py to use new generated code location #333

Closed
JustinBeckwith opened this issue Aug 29, 2018 · 2 comments
Closed

Update synth.py to use new generated code location #333

JustinBeckwith opened this issue Aug 29, 2018 · 2 comments
Assignees
@jkwlui
Labels
api: firestore Issues related to the googleapis/nodejs-firestore API. 🚨 This issue needs some love. triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@JustinBeckwith
Copy link
Contributor

Notes from this comment here:
#331 (comment)

@kinwa91 can you please work with @schmidt-sebastian to get generation working again?
@JustinBeckwith JustinBeckwith added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Aug 29, 2018
@JustinBeckwith JustinBeckwith added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Sep 3, 2018
@schmidt-sebastian
Copy link
Contributor

@kinwa91 Is there work remaining now that #337 is submitted?

@jkwlui
Copy link
Member

jkwlui commented Sep 6, 2018

This is fixed via #337

@jkwlui jkwlui closed this as completed Sep 6, 2018
@ghost ghost removed the priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. label Sep 6, 2018
@google-cloud-label-sync google-cloud-label-sync bot added the api: firestore Issues related to the googleapis/nodejs-firestore API. label Jan 31, 2020
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jkwlui jkwlui

Labels
api: firestore Issues related to the googleapis/nodejs-firestore API. 🚨 This issue needs some love. triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@JustinBeckwith @jkwlui @schmidt-sebastian @yoshi-automation