Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for OTel context propagation and harmonized spans #1833

Merged
merged 162 commits into from
Aug 24, 2024
Merged

feat: add support for OTel context propagation and harmonized spans #1833

merged 162 commits into from
Aug 24, 2024

Conversation

feywind
Copy link
Collaborator

@feywind feywind commented Sep 20, 2023

This PR adds support for OTel context propagation using the standard W3C headers as Pub/Sub attributes. It also harmonizes the spans we're using with the planned spans in other language libraries.

Fixes #1389

(This is the 4.x version of #1659 - I'll still be backporting to there, but the changes will go here first.)

feywind and others added 30 commits December 12, 2022 16:28
@feywind
feat: use the propagation inject framework for OpenTelemetry publishes
0d9c0b2
@feywind
feat: add propagation extraction to subscriber for OpenTelemetry
4f3daa9
@feywind
feat: work in progress on adding sub-spans
80d8b65
@feywind
add more spans
cbd5992
@feywind
wrap subscriber on() handlers to get better receive process spans
75acbab
@feywind
update otel core version for tests
bb6cf85
@feywind
fix: change some span names for doc updates
5cddaed
@feywind
fix: move emitter wrapper out one level, to catch user functions prop…
d523b1f 
…erly
@feywind
chore: merge remote-tracking branch 'remotes/origin/main' into otel-2
fbe29a2
@feywind
fix: don't send anything besides what's actually needed during publish
197a214
@feywind
fix: close the publish span at RPC time, not up front
a36cfce
@feywind
fix: delay caching of the trace provider so the user has a chance to …
5c4fef6 
…make one
@feywind
build: bring OTel versions back to compatible with Node 12
b58557d
@feywind
fix: clean up a few more namespace pollution issues in OTel support
4b7cf0c
@feywind
tests: manually end the publish span for tests
45047c7
@feywind
build: update package names for recent version updates
3995fd0
@feywind
chore: get versions of OTel that work together and with Node 12
f2f8f57
@feywind
chore: linter nit
4a2a79e
@feywind
chore: another linter nit
bb815d3
@feywind
chore: OTel sample formatting
5d60ff3
@feywind
chore: some internal renaming to reflect the function rather than nam…
f8a5c09 
…e of telemetry tracing
@feywind
fix: more work towards the Promise-first publish flow
d21480d
@feywind
tests: remove unnecessary init line
fe4947d
@feywind
fix: add tracing support for updating the topic name in publisher spans
568add9
@feywind
fix: use the most up to date name for topic, subscription, and iam
5243ea9
@feywind
fix: update telemetry spans before publishing, in case the topic name…
8dd13f8 
… wasn't ready
@feywind
chore: merge remote-tracking branch 'remotes/origin/main' into otel-2
60c70a8
@feywind
chore: merge remote-tracking branch 'remotes/origin/main' into otel-2
57c1673
@feywind
chore: merge remote-tracking branch 'remotes/origin/main' into otel-2
0a3b9a6
@feywind
chore: calm linter qualms
bc95037
@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 30, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 30, 2024
@generated-files-bot Generated Files Bot
Copy link

Warning: This pull request is touching the following templated files:

@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 7, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 7, 2024
@feywind
Copy link
Collaborator Author

feywind commented Aug 8, 2024

The otel-beta tag has been updated to 4.5.0-otel-beta.2, which is current as of today. This is pretty close now!

@feywind feywind added owlbot:run Add this label to trigger the Owlbot post processor. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Aug 23, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 23, 2024
@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 23, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 23, 2024
@feywind feywind merged commit 4b5c90d into googleapis:main Aug 24, 2024
15 checks passed
@release-please release-please bot mentioned this pull request Aug 24, 2024
Merged
This was referenced Sep 19, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hongalex hongalex hongalex approved these changes

Assignees

@feywind feywind

Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OpenTelemetry integration misses the point: we need to propagate the span/context!
7 participants
@feywind @omBratteng @weyert @Bishal18 @naseemkullah @hongalex @yoshi-kokoro