Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add option to disable emulator auth handling (temp fix) #1861

Merged
merged 6 commits into from
Feb 8, 2024

Conversation

feywind
Copy link
Collaborator

@feywind feywind commented Dec 14, 2023

Add manual control via PubSub options for whether the library uses "emulator mode", aka setting up for insecure SSL credentials for testing. Also fixes the heuristic to work with TPC.

@feywind feywind added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 14, 2023
@feywind feywind requested review from a team as code owners December 14, 2023 22:47
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: pubsub Issues related to the googleapis/nodejs-pubsub API. labels Dec 14, 2023
src/pubsub.ts Outdated
@@ -70,6 +70,7 @@ export type Omit<T, K extends keyof T> = Pick<T, Exclude<keyof T, K>>;

export interface ClientConfig extends gax.GrpcClientOptions {
apiEndpoint?: string;
useFakeCredentials?: boolean;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a comment on the bug, but we should seriously consider alternatives to just adding another property like this. If we do end up adding it, let's not call it "useFakeCredentials."

@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Feb 6, 2024
@feywind feywind added owlbot:run Add this label to trigger the Owlbot post processor. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Feb 6, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 6, 2024
@feywind
Copy link
Collaborator Author

feywind commented Feb 6, 2024

@kamalaboulhosn Mind taking another look at this and see if you're okay with what I changed? Unfortunately this is now blocking TPC updates. :\

src/pubsub.ts Outdated Show resolved Hide resolved
@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 8, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 8, 2024
@feywind feywind merged commit 761cdc8 into googleapis:main Feb 8, 2024
15 checks passed
@feywind feywind deleted the disable-emulator branch February 8, 2024 21:54
gcf-merge-on-green bot pushed a commit that referenced this pull request Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants