Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I just tried to upgrade and I am getting many cannot find type "Long" error #526

Closed
richtera opened this issue Mar 5, 2019 · 3 comments
Closed
Assignees
Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. priority: p2 Moderately-important priority. Fix may not be included in next release. status: duplicate Duplicate. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. TypeScript

Comments

@richtera
Copy link

richtera commented Mar 5, 2019

Thanks for stopping by to let us know something could be better!

Environment details

  • OS: Mac OS X
  • Node.js version: node v10
  • npm version: yarn 1.13.0
  • @google-cloud/pubsub version: Current 0.24.1 Tried to Upgrade to 0.27.0

Steps to reproduce

  1. Setup existing project using typescript
  2. Upgrade from 0.24.1 to 0.27.0

I don't know if there are other causes or setups I need to do. I have tried to add "types: ['Long']" into the compiler configuration but that didn't help. I found references to some other projects also using protobuf with similar problems, but I was unable to find a place where it presented a good solution.
I tried quite a few different approaches, but didn't get anywhere, sorry.

@callmehiphop callmehiphop added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. status: duplicate Duplicate. TypeScript labels Mar 6, 2019
@callmehiphop
Copy link
Contributor

Thanks for the report @richtera! Unfortunately this is an issue that can be found in a couple our libraries. I'm going to leave this issue open to make sure the fix lands in PubSub, but anyone running into this issue should subscribe to googleapis/nodejs-datastore#345 for now.

@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Mar 6, 2019
@callmehiphop callmehiphop reopened this Mar 8, 2019
@callmehiphop callmehiphop added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed triage me I really want to be triaged. labels Mar 8, 2019
@JustinBeckwith
Copy link
Contributor

@callmehiphop can you pull over the test I added to datastore along with this fix? Would be nice to make sure we don't mess this up again lol.

@callmehiphop
Copy link
Contributor

@richtera I just cut a new release (0.28), would you mind upgrading and testing to see if your issue is resolved? Thanks!

@callmehiphop callmehiphop reopened this Mar 11, 2019
@google-cloud-label-sync google-cloud-label-sync bot added the api: pubsub Issues related to the googleapis/nodejs-pubsub API. label Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. priority: p2 Moderately-important priority. Fix may not be included in next release. status: duplicate Duplicate. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. TypeScript
Projects
None yet
Development

No branches or pull requests

4 participants