Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!(deps): Internalize crc32c Hashing Functionality #1910

Closed
danielbankhead opened this issue May 5, 2022 · 1 comment
Closed

refactor!(deps): Internalize crc32c Hashing Functionality #1910

danielbankhead opened this issue May 5, 2022 · 1 comment
Assignees
@danielbankhead
Labels
api: storage Issues related to the googleapis/nodejs-storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@danielbankhead
Copy link
Member

Remove hash-stream-validation dependency in favor of an internalized version of this functionality.

BREAKING: Drop 'magic import' of fast-crc32c module in favor of allowing customers to pass an optional crc32c hashing interface.

  • This will provide a more customizable, reliable experience while allowing improved ES module & bundling support
  • Update documentation to reflect this change; remove references to fast-crc32c
@danielbankhead danielbankhead added priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern. labels May 5, 2022
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/nodejs-storage API. label May 5, 2022
@danielbankhead danielbankhead changed the title refactor!(deps): Internalize crc32c Hashing Functionality refactor!(deps): Internalize crc32c Hashing Functionality May 5, 2022
@danielbankhead
Copy link
Member Author

Implementation notes/references:

@danielbankhead danielbankhead self-assigned this May 12, 2022
This was referenced May 14, 2022
Merged
Merged
@shaffeeullah shaffeeullah mentioned this issue May 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielbankhead danielbankhead

Labels
api: storage Issues related to the googleapis/nodejs-storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@danielbankhead