Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: remove client side validation in favor of returning server side errors #1996

Closed
ddelgrosso1 opened this issue Jun 28, 2022 · 1 comment
Closed

Refactor: remove client side validation in favor of returning server side errors #1996

ddelgrosso1 opened this issue Jun 28, 2022 · 1 comment
Assignees
@ddelgrosso1
Labels
api: storage Issues related to the googleapis/nodejs-storage API. next major: breaking change this is a change that we should wait to bundle into the next major version type: cleanup An internal cleanup or hygiene concern.

Comments

@ddelgrosso1
Copy link
Contributor

Per @frankyn an audit was conducted to identify client side validations / exceptions that should be removed in favor of relying server side validation. This will reduce potential issues should the server ever change or add additional checks or types. I will link the appropriate documents to the internal tracking ticket. This is considered a breaking change as users may be relying on the current messages thrown from the client.
@ddelgrosso1 ddelgrosso1 added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p3 Desirable enhancement or fix. May not be included in next release. next major: breaking change this is a change that we should wait to bundle into the next major version labels Jun 28, 2022
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/nodejs-storage API. label Jun 28, 2022
@ddelgrosso1 ddelgrosso1 added type: cleanup An internal cleanup or hygiene concern. and removed type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Jun 28, 2022
@ddelgrosso1 ddelgrosso1 self-assigned this Jun 28, 2022
@ddelgrosso1 ddelgrosso1 removed the priority: p3 Desirable enhancement or fix. May not be included in next release. label Jul 13, 2023
@ddelgrosso1 ddelgrosso1 mentioned this issue Jul 13, 2023
Merged
4 tasks
@ddelgrosso1
Copy link
Contributor Author

Released with 7.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ddelgrosso1 ddelgrosso1

Labels
api: storage Issues related to the googleapis/nodejs-storage API. next major: breaking change this is a change that we should wait to bundle into the next major version type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ddelgrosso1