Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Resume Resumable Uploads #2333

Merged
merged 28 commits into from
Nov 1, 2023
Merged

feat: Resume Resumable Uploads #2333

merged 28 commits into from
Nov 1, 2023

Conversation

danielbankhead
Copy link
Contributor

Additionally, support uploading partial resumable uploads.

Fixes #2162 🦕

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Oct 16, 2023
@danielbankhead danielbankhead changed the title feat: Resume Resumable Upload feat: Resume Resumable Uploads Oct 16, 2023
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/nodejs-storage API. label Oct 16, 2023
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Oct 19, 2023
@danielbankhead danielbankhead marked this pull request as ready for review October 20, 2023 01:18
@danielbankhead danielbankhead requested review from a team as code owners October 20, 2023 01:18
@danielbankhead danielbankhead added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 20, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 20, 2023
@danielbankhead danielbankhead added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 20, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 20, 2023
@danielbankhead danielbankhead added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 20, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 20, 2023
ddelgrosso1
ddelgrosso1 reviewed Oct 23, 2023
View reviewed changes
src/file.ts Outdated Show resolved Hide resolved
@ddelgrosso1
Copy link
Contributor

Since this is a larger change let's walk through it when you have some time.

@danielbankhead danielbankhead added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 1, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 1, 2023
@danielbankhead danielbankhead merged commit 2ba4009 into main Nov 1, 2023
19 checks passed
@danielbankhead danielbankhead deleted the resume-resumable-upload branch November 1, 2023 17:12
@release-please release-please bot mentioned this pull request Nov 1, 2023
Merged
@release-please release-please bot mentioned this pull request Nov 8, 2023
Closed
@YoutacRandS-VA YoutacRandS-VA mentioned this pull request Jun 19, 2024
Open
This was referenced Jul 16, 2024
Open
Open
@snyk-io snyk-io bot mentioned this pull request Jul 16, 2024
Open
@WontonSam WontonSam mentioned this pull request Jul 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddelgrosso1 ddelgrosso1 ddelgrosso1 approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/nodejs-storage API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resume an incomplete upload
3 participants
@danielbankhead @ddelgrosso1 @yoshi-kokoro