Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixes bug in the test. #332

Merged
merged 3 commits into from
Aug 4, 2022
Merged

fix: fixes bug in the test. #332

merged 3 commits into from
Aug 4, 2022

Conversation

atulep
Copy link
Contributor

@atulep atulep commented Jul 26, 2022

Fixes failing test after new protobuf was released.

The ScalarMap is being returned and needs to be explicitly converted to dict for assertion to succeed.

@atulep atulep requested review from a team as code owners July 26, 2022 20:27
Copy link
Contributor

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atulep atulep merged commit f85f470 into main Aug 4, 2022
@atulep atulep deleted the protobuf_fixes branch August 4, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants