Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typo in legacy docs #2037

Merged
merged 2 commits into from
Oct 9, 2024
Merged

fix: typo in legacy docs #2037

merged 2 commits into from
Oct 9, 2024

Conversation

jeffqg
Copy link
Contributor

@jeffqg jeffqg commented Oct 1, 2024

Rewrite uspported -> supported.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2036 🦕

@jeffqg
Fix typo in legacy docs
d56b990 
uspported -> supported
@jeffqg jeffqg requested review from a team as code owners October 1, 2024 18:08
@jeffqg jeffqg requested a review from farhan0102 October 1, 2024 18:08
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Oct 1, 2024
@jeffqg jeffqg changed the title Fix typo in legacy docs fix: typo in legacy docs Oct 1, 2024
@conventional-commit-lint-gcf Conventional Commit Lint GCF
Copy link

conventional-commit-lint-gcf bot commented Oct 1, 2024 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@chalmerlowe chalmerlowe assigned chalmerlowe and unassigned tswast Oct 1, 2024
@chalmerlowe chalmerlowe added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 1, 2024
@chalmerlowe
Copy link
Collaborator

Let's have Kokoro do its thing and see if we can get this approved.

@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 1, 2024
@chalmerlowe chalmerlowe added kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Oct 8, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 8, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 8, 2024
@chalmerlowe chalmerlowe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 8, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 8, 2024
@chalmerlowe chalmerlowe added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Oct 8, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 9, 2024
@chalmerlowe chalmerlowe enabled auto-merge (squash) October 9, 2024 10:25
chalmerlowe
chalmerlowe approved these changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chalmerlowe chalmerlowe merged commit 1d8d0a0 into googleapis:main Oct 9, 2024
18 checks passed
@chalmerlowe
Copy link
Collaborator

@jeffqg

Thank you very much for submitting this fix. I appreciate the help.
If you are interested in working on another task, I would be happy to do what I can to facilitate.

Have a great day!

@jeffqg jeffqg deleted the typo-fix branch October 9, 2024 17:54
@jeffqg
Copy link
Contributor Author

jeffqg commented Oct 9, 2024

Thanks! I'm starting to use this API, so I'll try to address any issues I come across.

chalmerlowe added a commit that referenced this pull request Nov 1, 2024
@jeffqg @chalmerlowe
Fix typo in legacy docs (#2037)
8a30f0d 
uspported -> supported

Co-authored-by: Chalmer Lowe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalmerlowe chalmerlowe chalmerlowe approved these changes

@farhan0102 farhan0102 Awaiting requested review from farhan0102 farhan0102 is a code owner automatically assigned from googleapis/api-bigquery

Assignees

@chalmerlowe chalmerlowe

Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typo in legacy_proto_types.rst
4 participants
@jeffqg @chalmerlowe @tswast @yoshi-kokoro