Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v3: use defaults for inclusive flags #826

Open
daniel-sanche opened this issue Jun 29, 2023 · 0 comments
Open

v3: use defaults for inclusive flags #826

daniel-sanche opened this issue Jun 29, 2023 · 0 comments
Assignees
@daniel-sanche
Labels
api: bigtable Issues related to the googleapis/python-bigtable API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Milestone
v3-post GA

Comments

@daniel-sanche
Copy link
Contributor

We currently use None to for inclusive flags, and raise an error if the flag is set when the field is not. WE have this behaviour in both RowRange and RowFilter.

We should consider using default values in the signature instead, to make things simpler

Context: #820 (comment)
@daniel-sanche daniel-sanche added type: cleanup An internal cleanup or hygiene concern. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Jun 29, 2023
@daniel-sanche daniel-sanche added this to the v3-beta milestone Jun 29, 2023
@daniel-sanche daniel-sanche self-assigned this Jun 29, 2023
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/python-bigtable API. label Jun 29, 2023
@daniel-sanche daniel-sanche mentioned this issue Jun 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daniel-sanche daniel-sanche

Labels
api: bigtable Issues related to the googleapis/python-bigtable API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
v3-post GA
Development

No branches or pull requests
1 participant
@daniel-sanche