Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: require google-cloud-core >= 1.4.4 #226

Merged
merged 1 commit into from
Oct 6, 2023
Merged

fix: require google-cloud-core >= 1.4.4 #226

merged 1 commit into from
Oct 6, 2023

Conversation

vchudnov-g
Copy link
Contributor

@vchudnov-g vchudnov-g commented Oct 5, 2023 •
edited
Loading

This also removes the transitive dependency on package "six", which was causing presubmit failures.

@vchudnov-g vchudnov-g requested a review from a team as a code owner October 5, 2023 21:58
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: dns Issues related to the googleapis/python-dns API. labels Oct 5, 2023
@vchudnov-g vchudnov-g mentioned this pull request Oct 5, 2023
Merged
@vchudnov-g vchudnov-g changed the title fix(deps): Remove dependency on package "six" fix: require google-cloud-core >= 1.4.4 Oct 6, 2023
@vchudnov-g vchudnov-g merged commit 77a6545 into main Oct 6, 2023
17 checks passed
@vchudnov-g vchudnov-g deleted the remove-six branch October 6, 2023 15:11
@release-please release-please bot mentioned this pull request Oct 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parthea parthea parthea approved these changes

Assignees
No one assigned
Labels
api: dns Issues related to the googleapis/python-dns API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vchudnov-g @parthea