Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Introduce compatibility with native namespace packages #232

Merged
merged 3 commits into from
Nov 29, 2023

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Nov 15, 2023

This PR:

To obtain the version at runtime, use google.cloud.dns.__version__

(py39) partheniou@partheniou-vm-3:~/git/python-dns$ python3
Python 3.9.16 (main, Mar  2 2023, 17:52:22) 
[GCC 12.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import google.cloud.dns
>>> google.cloud.dns.__version__
'0.34.2'

@parthea parthea added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 15, 2023
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: dns Issues related to the googleapis/python-dns API. labels Nov 15, 2023
@parthea
Copy link
Contributor Author

parthea commented Nov 15, 2023

Adding do not merge as there is an upcoming release freeze. This should be merged after the release freeze ends on November 29th.

@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 23, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 23, 2023
@parthea parthea marked this pull request as ready for review November 29, 2023 21:54
@parthea parthea requested a review from a team as a code owner November 29, 2023 21:54
@parthea parthea removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 29, 2023
@parthea parthea merged commit 8e9f0be into main Nov 29, 2023
18 checks passed
@parthea parthea deleted the migrate-to-native-namespace-packages branch November 29, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: dns Issues related to the googleapis/python-dns API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants