page_size not needed for list_documents #887
Labels
api: firestore
Issues related to the googleapis/python-firestore API.
priority: p3
Desirable enhancement or fix. May not be included in next release.
type: cleanup
An internal cleanup or hygiene concern.
Milestone
We have three rpcs that use pagers: ListDocuments, ListCollectionIds, and PartitionQuery
Currently, onlt list_documents provides the user with a customizable page_size arg. But all 3 rpcs abstract the pages from the users, and provide them with a flat generator over the underlying resources, so it's debatable whether the page_size argument even makes sense to provide.
To be consistent, we should either remove it from list_documents, or provide it in all three
The text was updated successfully, but these errors were encountered: