Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support custom json parsers for CloudLoggingHandler #658

Open
daniel-sanche opened this issue Oct 26, 2022 · 0 comments
Open

feat: support custom json parsers for CloudLoggingHandler #658

daniel-sanche opened this issue Oct 26, 2022 · 0 comments
Labels
2023-triage api: logging Issues related to the googleapis/python-logging API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@daniel-sanche
Copy link
Contributor

We recently had a PR that adds custom JSON parser support for the StructuredLogHandler. No such feature exists for CloudLoggingHandler, which expects JSON-serializable objects only. It may be more user-friendly if both handlers supported this feature, and it could be configured as part of setup_logging

Related: #656
@daniel-sanche daniel-sanche added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Oct 26, 2022
@daniel-sanche daniel-sanche self-assigned this Oct 26, 2022
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/python-logging API. label Oct 26, 2022
@daniel-sanche daniel-sanche mentioned this issue Oct 26, 2022
Merged
@daniel-sanche daniel-sanche removed their assignment Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2023-triage api: logging Issues related to the googleapis/python-logging API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@daniel-sanche