Skip to content
This repository has been archived by the owner on Nov 29, 2023. It is now read-only.

Keep features as an keyword parameter in v1 #7

Closed
busunkim96 opened this issue Feb 13, 2020 · 0 comments · Fixed by #76
Closed

Keep features as an keyword parameter in v1 #7

busunkim96 opened this issue Feb 13, 2020 · 0 comments · Fixed by #76
Assignees
@busunkim96
Labels
api: videointelligence Issues related to the googleapis/python-videointelligence API. type: cleanup An internal cleanup or hygiene concern.

Comments

@busunkim96
Copy link
Contributor

busunkim96 commented Feb 13, 2020 •
edited
Loading

See https://github.com/googleapis/python-videointelligence/pull/5/files for detailed discussion.

features should be kept as an optional parameter via a synthtool replace until we move to the microgenerator, at which point this can taken with the other breaking changes.

The replacement should have a comment (where appropriate) linking back to this issue so the change is not accidentally merged.
@busunkim96 busunkim96 self-assigned this Feb 13, 2020
@product-auto-label product-auto-label bot added the api: videointelligence Issues related to the googleapis/python-videointelligence API. label Feb 13, 2020
@busunkim96 busunkim96 mentioned this issue Feb 13, 2020
Merged
@busunkim96 busunkim96 added type: cleanup An internal cleanup or hygiene concern. and removed api: videointelligence Issues related to the googleapis/python-videointelligence API. labels Feb 13, 2020
@busunkim96 busunkim96 changed the title Keep features as an keyword parameter Keep features as an keyword parameter in v1 Jun 10, 2020
@product-auto-label product-auto-label bot added the api: videointelligence Issues related to the googleapis/python-videointelligence API. label Jul 10, 2020
@danoscarmike danoscarmike mentioned this issue Nov 19, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@busunkim96 busunkim96

Labels
api: videointelligence Issues related to the googleapis/python-videointelligence API. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: use microgenerator danoscarmike/python-videointelligence
1 participant
@busunkim96