Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When using release-please on GitHub enterprise, some links at changelog/release points to github #2351

Open
goatwu1993 opened this issue Aug 7, 2024 · 0 comments · May be fixed by #2350
Open

When using release-please on GitHub enterprise, some links at changelog/release points to github #2351

goatwu1993 opened this issue Aug 7, 2024 · 0 comments · May be fixed by #2350
Assignees
@chingor13
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@goatwu1993
Copy link
Contributor

goatwu1993 commented Aug 7, 2024 •
edited
Loading

Description

When using release-please-action v4 on github enterprise (e.g https://self-host.github.example.com), changelog-host needs to be configured in release-please-config, or else some links in changelog.md and releases will point to github.com

By default i expect github enterprise to have correct links without extra configuration.

Environment details

  • OS:
  • Node.js version:
  • npm version:
  • release-please version: 16.12.0 (release-please-action)

Steps to reproduce

  1. ?
  2. ?

Making sure to follow these steps will guarantee the quickest resolution possible.

Thanks!
@goatwu1993 goatwu1993 added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Aug 7, 2024
@goatwu1993 goatwu1993 linked a pull request Aug 7, 2024 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chingor13 chingor13

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fix links error when using GitHub Enterprise goatwu1993/release-please
2 participants
@chingor13 @goatwu1993