grpc: object upload issues found by java retry conformance tests #574
Labels
priority: p2
Moderately-important priority. Fix may not be included in next release.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
While updating the java retry conformance suite to also run for
transport: GRPC
I ran into two oddities in the testbenchretry_test
integration with grpc.storage.object.create
instructions do not apply toStartResumableWrite
Java treats all resumable upload PUTs as idempotent. Because the instruction isn't being processed until
WriteObject
, java still retries. This is inconsistent with JSONs handling, which does apply instructions to starting a resumable upload.WriteObject
does not finalize a resumable session sometimesWhen testbench receives a
WriteObjectRequest
withfinish_write: true
without anychecksummed_data
it incorrectly response with an incremental response rather than the resources.>>>
message sent<<<
message receivedThe
checksummed_data
inWriteObjectRequest
is in theoneof data
declaration. Because it is declared in theoneof
it is implicitly optional and need to be present in the message.AIP-146 touches on this briefly
Testbench will need to be updated to account for this.
The text was updated successfully, but these errors were encountered: