From adcb6fa51f908d08207fc51c62307e0782145e48 Mon Sep 17 00:00:00 2001 From: Megan Potter Date: Thu, 6 Aug 2020 15:18:26 -0700 Subject: [PATCH 1/2] fix: make mocha tests for node libraries recursive ... it seems to have been the case in the past --- synthtool/gcp/templates/node_library/.mocharc.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/synthtool/gcp/templates/node_library/.mocharc.js b/synthtool/gcp/templates/node_library/.mocharc.js index ff7b34fa5..0b600509b 100644 --- a/synthtool/gcp/templates/node_library/.mocharc.js +++ b/synthtool/gcp/templates/node_library/.mocharc.js @@ -14,7 +14,8 @@ const config = { "enable-source-maps": true, "throw-deprecation": true, - "timeout": 10000 + "timeout": 10000, + "recursive": true } if (process.env.MOCHA_THROW_DEPRECATION === 'false') { delete config['throw-deprecation']; From e80efd5f33147b15d8bcdb13d85d05c4799d0bbf Mon Sep 17 00:00:00 2001 From: Megan Potter Date: Fri, 11 Sep 2020 17:06:45 -0700 Subject: [PATCH 2/2] build: run tests with strict node engine checking [bcoe] --- synthtool/gcp/templates/node_library/.github/workflows/ci.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/synthtool/gcp/templates/node_library/.github/workflows/ci.yaml b/synthtool/gcp/templates/node_library/.github/workflows/ci.yaml index a33836a6f..be8c99051 100644 --- a/synthtool/gcp/templates/node_library/.github/workflows/ci.yaml +++ b/synthtool/gcp/templates/node_library/.github/workflows/ci.yaml @@ -16,7 +16,7 @@ jobs: with: node-version: ${{ '{{' }} matrix.node {{ '}}' }} - run: node --version - - run: npm install + - run: npm install --engine-strict - run: npm test - name: coverage uses: codecov/codecov-action@v1