core: enhanced noopener output #5857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
approved these changes
Aug 17, 2018
There was a problem hiding this comment.
LGTM!
(with question over to @paulirish which probably should just result in filing a new issue if I'm actually remembering)
| } | ||
|
|
||
| module.exports = { | ||
| getElementsInDocumentFnString: getElementsInDocument.toString(), |
There was a problem hiding this comment.
@paulirish I can't remember if you were an advocate for all the page functions to be exposed as strings or if it was the opposite (or if your opinion has changed over time)
There was a problem hiding this comment.
hmmm i dont think i cared, but i like the idea of them being exported as strings.
we can do in a followup. 👩🚒
There was a problem hiding this comment.
followup sg :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
cleans up TODO for including outerHTML in noopener link audit and does some related page-functions/dom-helpers cleanup along the way :)