Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc(proto): adjust configSetting.output in preprocessor #6310

Merged
merged 4 commits into from
Oct 18, 2018

Conversation

exterkamp
Copy link
Member

Summary
Adds configSettings.output processing.

Related Issues/PRs
preprocessing for: #6309

@exterkamp exterkamp changed the title Added output to preprocessor. misc(proto): added output processing to preprocessor Oct 17, 2018
@paulirish paulirish changed the title misc(proto): added output processing to preprocessor misc(proto): adjust configSetting.output in preprocessor Oct 17, 2018
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a style thing, but otherwise LGTM!

lighthouse-core/lib/proto-preprocessor.js Outdated Show resolved Hide resolved
lighthouse-core/lib/proto-preprocessor.js Outdated Show resolved Hide resolved
@paulirish paulirish merged commit 771fb5a into master Oct 18, 2018
@paulirish paulirish deleted the bug/preprocessor branch October 18, 2018 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants