Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

viewer: allow loading RunnerResult json #7031

Merged
merged 3 commits into from
Jan 21, 2019
Merged

viewer: allow loading RunnerResult json #7031

merged 3 commits into from
Jan 21, 2019

Conversation

paulirish
Copy link
Member

If you want to drop the full RunnerResult json into the viewer, it should work.

cc @benschwarz

patrickhulce
patrickhulce approved these changes Jan 17, 2019
View reviewed changes
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

This could even have fancier stuff if we wanted like "Looks like you've got the full artifacts too! Want to open the trace in DevTools?" :D

@connorjclark
Copy link
Collaborator

typescript error:

lighthouse-viewer/app/src/lighthouse-report-viewer.js(141,19): error TS2339: Property 'lhr' does not exist on type 'ReportResult'.

brendankenny
brendankenny approved these changes Jan 21, 2019
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM2

Appveyor error is just appveyor/pwa smoke usual thing

@brendankenny brendankenny merged commit 11021ff into master Jan 21, 2019
@brendankenny brendankenny deleted the viewerlhr branch January 21, 2019 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhulce patrickhulce patrickhulce approved these changes

@brendankenny brendankenny brendankenny approved these changes

@ebidel ebidel Awaiting requested review from ebidel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paulirish @connorjclark @brendankenny @patrickhulce