core(tsc): polish switch to new audit-details types #7285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
requested review from
patrickhulce and
paulirish
as code owners
brendankenny
commented
Feb 20, 2019
| @@ -447,7 +447,6 @@ class ReportUIFeatures { | |||
| */ | |||
| getReportHtml() { | |||
| this._resetUIState(); | |||
| // @ts-ignore - technically documentElement can be null, but that's dumb - https://dom.spec.whatwg.org/#document-element | |||
There was a problem hiding this comment.
this was unrelated, but noticed it when I was searching for @ts-ignore. Fixed in some tsc release since the comment was added.
patrickhulce
approved these changes
Feb 21, 2019
| @@ -151,8 +151,7 @@ class UnusedCSSRules extends ByteEfficiencyAudit { | |||
| } | |||
|
|
|||
| const usage = UnusedCSSRules.computeUsage(stylesheetInfo); | |||
| // @ts-ignore TODO(bckenny): fix index signature on ByteEfficiencyItem. | |||
| return Object.assign({url}, usage); | |||
| return {url, ...usage}; | |||
| @@ -207,7 +201,7 @@ class DetailsRenderer { | |||
| // The value's type overrides the heading's for this column. | |||
| switch (value.type) { | |||
| case 'code': { | |||
| return this._renderCode(value); | |||
| return this._renderCode(value.value); | |||
There was a problem hiding this comment.
🤔 not that it's new, but seems like we need a new local name for value
There was a problem hiding this comment.
but seems like we need a new local name for
value
haha, yeah. I actually like the local value and would rather change the property (e.g. value.code), but that's probably way too much for now :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes a few leftover
TODOs and@ts-ignores and removed the middle man on some of the details types being wrapped in an object and then immediately unwrapped again.With this PR the
LH.Audit.Detailsfix process should be finished.