Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc: remove obsolete Util.formatDisplayValue #7628

Merged
merged 1 commit into from
Mar 22, 2019
Merged

misc: remove obsolete Util.formatDisplayValue #7628

merged 1 commit into from
Mar 22, 2019

Conversation

brendankenny
Copy link
Member

#6767 finally put to bed the non-string version of displayValue, but we forgot to remove Util.formatDisplayValue, which was always returning on the first two lines of the function (either identity or '' :)

patrickhulce
patrickhulce approved these changes Mar 22, 2019
View reviewed changes
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huzzah! 🎉

exterkamp
exterkamp approved these changes Mar 22, 2019
View reviewed changes
Copy link
Member

@exterkamp exterkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@brendankenny brendankenny merged commit fe63e72 into master Mar 22, 2019
@brendankenny brendankenny deleted the dv branch March 22, 2019 19:12
@brendankenny brendankenny mentioned this pull request Aug 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exterkamp exterkamp exterkamp approved these changes

@patrickhulce patrickhulce patrickhulce approved these changes

@paulirish paulirish Awaiting requested review from paulirish

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brendankenny @patrickhulce @exterkamp